-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Fix error: '__outer_iterator' redeclared with 'public' access #161859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes the following compilation error: ``` $(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__ranges/lazy_split_view.h:143:10: error: '__outer_iterator' redeclared with 'public' access 143 | struct __outer_iterator : __outer_iterator_category<__maybe_const<_Const, _View>> { | ^ $(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__ranges/lazy_split_view.h:79:10: note: previously declared 'private' here 79 | struct __outer_iterator; ```
@llvm/pr-subscribers-libcxx Author: Yuriy Chernyshov (georgthegreat) ChangesFixes the following compilation error:
Full diff: https://github.com/llvm/llvm-project/pull/161859.diff 1 Files Affected:
diff --git a/libcxx/include/__ranges/lazy_split_view.h b/libcxx/include/__ranges/lazy_split_view.h
index cca9191d26818..7471579653d20 100644
--- a/libcxx/include/__ranges/lazy_split_view.h
+++ b/libcxx/include/__ranges/lazy_split_view.h
@@ -76,6 +76,7 @@ class lazy_split_view : public view_interface<lazy_split_view<_View, _Pattern>>
_If<!forward_range<_View>, __non_propagating_cache<iterator_t<_View>>, __empty_cache>;
_LIBCPP_NO_UNIQUE_ADDRESS _MaybeCurrent __current_ = _MaybeCurrent();
+private:
template <bool>
struct __outer_iterator;
template <bool>
|
This backports [PR #161859](llvm/llvm-project#161859) from upstream. commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
This backports [PR #161859](llvm/llvm-project#161859) from upstream. commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
This backports [PR #161859](llvm/llvm-project#161859) from upstream. commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
This backports [PR #161859](llvm/llvm-project#161859) from upstream. commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
This backports [PR #161859](llvm/llvm-project#161859) from upstream. commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
This backports [PR #161859](llvm/llvm-project#161859) from upstream. commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
This backports [PR #161859](llvm/llvm-project#161859) from upstream. commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a reproducer/test for this? This looks to me like a compiler bug, not a libc++ bug.
This backports [PR #161859](llvm/llvm-project#161859) from upstream. commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
Fixes the following compilation error: